Atlassian JIRA   History | Log In     View a printable version of the current page. Get help!  
Issue Details [XML]

Key: XRP-102
Type: New Feature New Feature
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Reporter: Jurgen De Moortel
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
xReporter

Charts

Created: 01/Feb/06 09:46 AM   Updated: 20/Sep/07 11:07 AM
Component/s: xReporter-Cocoon
Affects Version/s: SVN-HEAD
Fix Version/s: 1.3

File Attachments: 1. Text File charts-diff.txt (112 kb)
2. Text File charts.patch (189 kb)
3. Zip Archive xreporter-cocoon-1.2.1.zip (3.47 Mb)

Issue Links:
Duplicate
This issue duplicates:
XRP-76 Enable charting of report result Minor Resolved
 


 Description   
This patch makes it possible to create several charts on a report.
It is poosible for the end-user to define his own chart.
It is also possible for the report creator to define a standard chart. So the end-user can use these charts.

 All   Comments   Change History      Sort Order:
Comment by Marc Portier [08/Feb/07 09:46 AM]
integrating the XRP-102 patch should solve this as well

Comment by Bruno Dumon [14/Sep/07 09:36 AM]
I did a first exploration of this patch, since this issue is related to the pluggable output formats per report.

Some general observations:
 - please [in the future] make diffs always in the root of the source tree, not in a higher or lower directory level, this makes the patch easier and safer to apply
 - in the changed files, it is very hard to follow what is actually changed because of source layout changes (not just spaces-to-tabs changes)

I will attach an updated patch which at least makes the changes in sitemap.xmap and layout.xsl readable (and also fixed some obvious errors, like a double "fins-serialize" resource and some other things which were introduced by accident).

Some more observations:
* layout.xsl uses a non-exising formatLinks template
* since this requires fins, the initial setup work for xReporter will become [even] more involved (because of the need to install the fins block in the Cocoon source tree)

Notes on getting fins compiled:
 - the batik jar in Cocoon 2.1.10 is 1.6, and is located in lib/optional
 - since our local.blocks.properties excludes everything by default, need to add an include.block.fins=true
 - in gump.xml, needed to add dir="src/blocks/fins"

Also missing are docs on how to use this, I've queried the relevant person in private.

Comment by Jurgen De Moortel [18/Sep/07 03:02 AM]
The xreporter-cocoon directory (version 1.2.1) extended with the charts-patch

Comment by Bruno Dumon [20/Sep/07 10:56 AM]
The charts patch has now been integrated.

The charts things themselves have been left pretty much untouched, except for a few changes:

* renamed f:dataselectie to f:dataselection
* renamed f:transparancy to f:transparency
* i18n now works by embedding <i18n:text> tags instead of using the 'format:' prefix
* the sitemap.xmap references the chart XSLs 'hardcoded', i.e. not via the skin.

The index file stuff has also been integrated, though this part has changed a bit more, I'll describe that later when resolving XRP-75.

Some basic documentation on the charts can be found here
http://cocoondev.org/xreporter/docs/presentation/514-cd.html

Comment by Bruno Dumon [20/Sep/07 11:07 AM]
I'll add here some more comments on the differences between the 'index
file' system of the charts patch and what was actually implemented in
xReporter. A more complete description can be found in the documentation.

- In the charts patch the idx:group and idx:entry elements followed
  the file system structure: an idx:group corresponded to a directory
  and an idx:entry to a file in that directory.

  In the implemented system, the idx:group elements only serve to
  visually group several items together, it has no structural meaning.
  The idx:group elements can be nested inside each other to create
  a multi-level hierarchy. Use of idx:group is not obliged (= you
  can have top-level idx:entry's)

- Since there is no relation anymore between the idx:group's and the
  idx:entry's, the idx:entry's always need to have boh dir and file attributes

- The titles of idx:group are specified by a child idx:title tag.
  These can contain <i18n:text> tags for internationalization.

- The titles of idx:entry tags are, as before, derived from the
  f:name in the format files. For internationalization those should
  now also use <i18n:text> tags.