Atlassian JIRA   History | Log In     View a printable version of the current page. Get help!  
Issue Details [XML]

Key: XRP-72
Type: Improvement Improvement
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Reporter: Bill Bruyn
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
xReporter

Ensure well-formedness following SQLException

Created: 02/May/05 05:48 PM   Updated: 27/Oct/07 08:16 PM
Component/s: xReporter
Affects Version/s: None
Fix Version/s: 1.3


 Description   
The infamous error message

The element type "xr:row" must be terminated by the matching end-tag "</xr:row>"

is a consequence of using SAX for streaming the output, and
allowing sending part of the result even if we don't know yet that
everything will be ok

to get it 'cleaner' one:
- either you hog up all output to see if any exceptions are there before
emitting anything and you loose the streaming benefits (specially for
large resultsets)
- either you track all the opened xml tags so you can still close those
when injecting the error-message which will cost some extra processing
and might give you wellformedness, but still yield some strange mix of
half-way broken off output and error-message in the xml

in short it's a matter of performance over 'clean-ness'
(and we might question how 'clean' error-conditions can get, right?
  in these cases you just need to check the log)


But this comes up a lot. Do we need to handle this more cleanly, or is it enough to more clearly document the condition?

 All   Comments   Change History      Sort Order:
Comment by Bruno Dumon [13/Sep/07 11:20 AM]
Fixed/implemented in SVN rev 719-720.

The xReporter server now buffers the produced XML until is ended successfully. If an error occurs, the Java stacktrace information is embedded in the response so that it can be displayed in the frontend.